Wireshark-bugs: [Wireshark-bugs] [Bug 4997] Wireshark SSTP dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 16 Jul 2010 04:10:39 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4997

--- Comment #4 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2010-07-16 13:10:36 CEST ---
Oke, first of all please convert from a plugin to a build-in dissector.

Quick review:
I'm missing the full header on the dissector source file. Please look at the
template in doc/README.developer.
All that stuff in the include file doesn't represent an external interface,
just dissector specific data. Please fold this back into the dissector source
file.
Your protocol handoff doesn't handle range preference changes, hence that
doesn't work. Do you actually need this?
You leak memory with tvb_get_string()
check_col() is deprecated since 1.4

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.