Wireshark-bugs: [Wireshark-bugs] [Bug 4877] wireshark 1.4.0rc1 gets build warnings in epan/disse
Date: Mon, 14 Jun 2010 18:33:58 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4877

--- Comment #3 from Jose Pedro Oliveira <jpo@xxxxxxxxxxxx> 2010-06-14 18:33:57 PDT ---
(In reply to comment #2)
> > it builds with autotools (./configure; make)
> 
> It does?

Yes.

> If so, that means that the CMake build is turning on more warning flags than
> the automake build, or is building with -Werror.

Also true. I reported one of the differences at the end of ticket #4788:

 * configure: python off by default;
 * cmake: python on by default

Note: there is also an annoyance when wireshark is built with python support
and tshark is executed from the build directory (see end of #4788).

Should I open a new ticket about this?

> 
> There are two changes to epan/dissectors/packet-gtpv2.c that need to be
> propagated to the 1.4 branch:
> 
> ------------------------------------------------------------------------
> r33159 | etxrab | 2010-06-08 03:37:03 -0700 (Tue, 08 Jun 2010) | 1 line
> 
> Remove C++ style comment.
> ------------------------------------------------------------------------
> r33158 | etxrab | 2010-06-08 01:55:07 -0700 (Tue, 08 Jun 2010) | 1 line
> 
> Fix packet-gtpv2.c:945:1: error: "/*" within comment
> 
> I've added them to the list of changes to put into 1.4.0rc2.

I was too slow submitting a new comment mentioning the changes in the devel
trunk.

Regards,
jpo

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.