Wireshark-bugs: [Wireshark-bugs] [Bug 2631] B.A.T.M.A.N. Advanced dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 2 Jun 2010 13:58:18 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2631

--- Comment #54 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-06-02 16:58:16 EDT ---
(In reply to comment #51)
> Ok, it doesn't make a difference to the resulting calculation as the bit you
> added is removed by the >> 3... but I don't understand your intention to change
> it

Right....

I considered that the '>>3' might be incorrect but for the following reason
thought not.

    guint8 downbits = (gwflags & 0x7C) >> 3;
    guint8 upbits = (gwflags & 0x07);

The 0x7C and the 0x07 masks actually 
overlap by one bit which didn't seem
right. (I wouldn't expect that two fields overlap).


So: I felt the 0x7C was probably a typo and should actually be 0x78. In any
case, as you noted, the change I made didn't actually change the result.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.