Wireshark-bugs: [Wireshark-bugs] [Bug 3534] IETF ForCES(Forwarding and Control Element Separatio
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 1 Jun 2010 11:42:02 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3534

Gerald Combs <gerald@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gerald@xxxxxxxxxxxxx

--- Comment #5 from Gerald Combs <gerald@xxxxxxxxxxxxx> 2010-06-01 11:42:00 PDT ---
Should num2messagetype, num2tlvtype, and num2operationtype be replaced with
value strings?

There are a lot of places where the dissector adds a uint32 formatted as an
IPv4 address:

               temp=tvb_get_ntohl(tvb, offset+4);
               sid=tvb_get_ptr(tvb,offset+4 ,4);
               proto_tree_add_uint_format(
forces_main_header_tree,hf_forces_sid, tvb, 4, 4, temp,"Source
ID:%s",ip_to_str((guint8 *) sid));

Is there a reason for doing that instead of using proto_tree_add_item with
FT_IPv4?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.