Wireshark-bugs: [Wireshark-bugs] [Bug 4744] IPFIX Option templates incorrectly decoded
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 4 May 2010 13:04:53 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4744

--- Comment #2 from Andrew Feren <acferen@xxxxxxxxx> 2010-05-04 13:04:52 PDT ---
Created an attachment (id=4616)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4616)
patch for decoding IPFIX option templates

Patch includes.

warning for flow record with no flow information.  This isn't directly related
to the options template, but I added it after constructing a packet to trigger
what looked like an unreachable condition.

Cleaned up the logic in dissect_v9_pdu.  dissect_v9_pdu_data was getting called
twice for IPFIX option templates.  The second call never did anything.

Added a warning commnet that the variable names are confusing in some contexts.

removed second subtraction of option_len from option_scope_len.  This line is
the actual bug fix.

Testing notes.
Set 2 in packets 1 and 3 should now decode correctly.  3 scope fields in packet
1.  3 scope and 3 data fields in packet 3.

packet 2 contains not flow information to test my warning.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.