Wireshark-bugs: [Wireshark-bugs] [Bug 4733] Additional disseminator module for the 'bitscope.net
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 4 May 2010 04:28:07 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4733

--- Comment #1 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2010-05-04 13:28:04 CEST ---
Quick review:
Wireshark is licensed GPL 2 or later, yours "... can be redistributed under the
Apache Software License, or any BSD License ...". 
The "Apache License" is an ambiguous identification, because v1.0, v1.1 and
v2.0 exist. Assuming the latter, this only works with GPL v3.
Looking at http://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses
it seems that the only way this works is to assume the "Modified BSD license".
Still it requires documentation work for the binary distribution. A re-license
as GPL would make life much easier.

Now for the code:
check_col() is obsolete for new code.
No C++ style comments please,
No need to extract the values from the TVB, because...
... Replace proto_tree_add_uint_format() by proto_tree_add_item()

and pray the controlling host doesn't use UDP port 0x4001 too :)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.