Wireshark-bugs: [Wireshark-bugs] [Bug 4664] USB URB hex bytes not shown in "packet bytes" pane.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 22 Apr 2010 11:51:17 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4664

--- Comment #14 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-04-22 11:51:04 PDT ---
Thanks Guy!

BTW, did you notice the if (wth->file_encap == WTAP_ENCAP_ATM_PDUS) { ... }
block in libpcap.c:libpcap_read() and libpcap_seek_read that is conspicuously
missing from in pcapng.c:pcapng_read_packet_block() and
pcapng_read_simple_packet_block()?

It looks like an unintentional omission to me, but I'm not entirely sure.  I
thought that block, if indeed common to both, would be better placed in the new
pcap-common.c:pcap_read_post_process() function.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.