Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 4186] Support for VMware Lab Manager Host Spanning

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4186

Bill Meier <wmeier@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wmeier@xxxxxxxxxxx

--- Comment #19 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-04-05 11:08:50 PDT ---
One of the buildbot compilers complained about a possibly uninitialized
variable:

  packet-vmlab.c: In function 'dissect_vmlab':
  packet-vmlab.c:92: warning: 'encap_proto' may be used uninitialized in this
function


Looking at the code, I think that the 'if (tree)' in dissect_vmlab would have
the effect that ethertype would be called with incorrect args (eg: offset ) if
the value of tree is NULL.

So: I've removed the 'if (tree)'.

I've also made a few changes in the hf[] array.

See:

http://anonsvn.wireshark.org/viewvc?view=rev&revision=32385
http://anonsvn.wireshark.org/viewvc?view=rev&revision=32386


I'd appreciate it if you could make sure everything is still OK.

Thanks

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.