Wireshark-bugs: [Wireshark-bugs] [Bug 4590] ANCP (Access Node Control Protocol) Dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 2 Apr 2010 00:19:31 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4590

--- Comment #15 from Aniruddha <aniruddha.a@xxxxxxxxx> 2010-04-02 00:18:56 PDT ---
(In reply to comment #14)
> (In reply to comment #13)
> > Created an attachment (id=4465)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4465) [details]
[details]
> > patch with stats change
> 
> The Stats change looks OK to me....
> 
> 
> The dissector was committed in SVN #32353.
> 
> I made a few minor changes::
> 
> - Make ancp_info a local variable rather than a static global variable;
> - Use Stats ! ANCP   rather than Stats ! ANCP ! Packet Types.
> 
> 
> Thanks for your work !

Thanks, Bill.

For the detailed review, changes and commit.


--
Ani

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.