Wireshark-bugs: [Wireshark-bugs] [Bug 4505] Wireshark crashes during IEEE 802.15.4 decryption
Date: Mon, 22 Feb 2010 11:54:37 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4505

Owen Kirby <osk@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4309|review_for_checkin?         |
               Flag|                            |
   Attachment #4309|0                           |1
        is obsolete|                            |
   Attachment #4312|                            |review_for_checkin?
               Flag|                            |

--- Comment #7 from Owen Kirby <osk@xxxxxxxxxx> 2010-02-22 11:54:30 PST ---
Created an attachment (id=4312)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4312)
Fix for malformed IEEE 802.15.4 decryption.

This patch fixes some of the problems identified by Guy.

Calls to tvb_set_reported_length() have been removed as they are redundant. I
recall there was once a good reason I had included those calls but I forget
what that was and its not likely relevant anymore.

Changed the name of the data source from "IEEE 802.15.4 decryption" to
"Decrypted IEEE 802.15.4 payload"

Also, my comment regarding the use of tvb_get_ptr() was more a defense of
accessing the tvb's data directly instead of allocating an ephemeral copy using
ep_tvb_memdup(), which seems to be considered the safer thing to do.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.