Wireshark-bugs: [Wireshark-bugs] [Bug 4454] new dissector: 3GPP2 X.P0059-200
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 8 Feb 2010 18:58:42 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4454

--- Comment #3 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-02-08 18:58:39 PST ---
A few additional comments:

In hf[] array:
 FT_STRING requires BASE_NONE;

Please use consistent indentation;

We prefer to have proto_register... and proto_reg_handoff... be the last two 
functions in the source file.

hton16 and hton32 don't appear to be used so they (and the typedefs for uint16
and uint32) shouldn't be defined.

If these are needed, please use g_htons & g_htonl rather than defining your own
hton16 and hton32.
(See the GLib documentation).

B64Chars[] doesn't appear to be used anyplace;

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.