https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3934
--- Comment #12 from dragonlinux@xxxxxxxxx 2010-01-29 12:45:18 PST ---
(In reply to comment #11)
> (From update of attachment 4207 [details])
> 1. It does not compile because of several uninitialized variables.
>
Please post your compiling log here. I can compile and I have tested the
patches before I posted here.
> 2. The use of tvb_get_ptr() should be eliminated, please use appropriate
> proto_tree_add_* functions.
>
> 3. We have functions to print Ethernet addresses, look in epan/to_str.c
>
> 4. You do not need to include comments from the examples in README.developer.
>
> 5. CRC handling should be moved to epan/crc/
>
> 6. The file heading is not correct.
>
This is true. Indent mess this up and I didn't realize.
> 7. You have a lot of unused hf_ entries, check with tools/checkhf.pl
>
I will check one by one but some are used for sure and it reports unused.
> 8. Try use a proper proto_tree_add_ function instead of proto_tree_add_text.
>
> 9. Use functions instead of using goto inside a switch statement.
I will see what I can do with these suggestions.
thanks.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
