Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 1123] Index multiple instances of the same field name to reduce preferences fi

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1123

Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|High                        |Medium
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |
            Summary|Bloat of the preferences    |Index multiple instances of
                   |file ESP settings!          |the same field name to
                   |                            |reduce preferences file
                   |                            |size
           Severity|Major                       |Enhancement

--- Comment #5 from Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> 2010-01-29 13:30:10 MST ---
I just noticed that the IEEE 802.11 keys are repeated 64 times along with the
comments in the preferences file.  This bug came to mind since it dealt with
ESP that Ulf mentioned.  The wep key part is repeated 64 times, where X is a
number 1 to 64:

# Key #X string can be:   <wep hexadecimal key>;   wep:<wep hexadecimal key>;  
wpa
pwd:<passphrase>[:<ssid>];   wpa-psk:<wpa hexadecimal key>
# A string.
wlan.wep_keyX: 

How about introducing the concept of an index number for each value in the
preferences file?  Then change the code to only write as many entries as the
user is using under a single comment header.  This could allow any number of
duplicate entires without wasting any space when the user isn't using them.  We
could even reduce the code in the dissectors by making a routine to cycle
through the preferences file and return the value of each entry found instead
of having a seperate preferences call for every entry.  Then the preferences
screen could have a button that lets the user add additional entries after the
first one is shown and filled in.  I imagine the preferences file looking
something like this:

# Key strings can be:   <wep hexadecimal key>;   wep:<wep hexadecimal key>;  
wpa-pwd:<passphrase>[:<ssid>];   wpa-psk:<wpa hexadecimal key>
# A string with an index.
wlan.wep_key.1: data
wlan.wep_key.2: data
wlan.wep_key.3:  data

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.