Wireshark-bugs: [Wireshark-bugs] [Bug 4434] Dissectors for VSNCP and VSNP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 28 Jan 2010 09:03:29 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4434

Bill Meier <wmeier@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wmeier@xxxxxxxxxxx

--- Comment #2 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-01-28 09:03:27 PST ---
After a very quick look I note a few issues:

1. Several of the value_string arrays do not have a terminating 0,NULL entry.

2. In the hf[]array if the "blurb" text is exactly the same as the "name"
field, please use NULL for the blurb text pointer.

3. Re:
+  if(check_col(pinfo->cinfo, COL_PROTOCOL))
+    col_set_str(pinfo->cinfo, COL_PROTOCOL,
+        proto_get_protocol_short_name(find_protocol_by_id(proto_vsncp)));

   - check_col no longer required;
   - no need to look up the shortname; just use "vsncp" since that was 
     specified as the short name in proto_register...

4. There's at least one // form comment which should be changed to /*  ... */

5. Has this dissector been fuzz-tested ??

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.