Wireshark-bugs: [Wireshark-bugs] [Bug 4422] New: Enhancement: constify parameters in proto.c, pa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 26 Jan 2010 13:56:01 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4422

           Summary: Enhancement: constify parameters in proto.c, packet.c,
                    conversation.c, tvbuff.c
           Product: Wireshark
           Version: SVN
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: mykaul@xxxxxxxxx


Created an attachment (id=4181)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4181)
conversation.c.diff

Build Information:
SVN r31686.
--
These patches try to constify as many parameters as I could find.
Some compilers won't need this optimization, some may benefit from it, and
code-clarity wise it's a good idea.
It passed compilation tests.

epan/dissectors/packet-x11.c is the only one that had to be patched (except for
the couples packet.c/h, proto.c/h, tvbuff.c/h, conversation.c/h

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.