Wireshark-bugs: [Wireshark-bugs] [Bug 4406] New: Wireshark GUI not reporting filename after save
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4406
Summary: Wireshark GUI not reporting filename after save of new
capture file
Product: Wireshark
Version: SVN
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: Medium
Component: Wireshark
AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
ReportedBy: jyoung@xxxxxxx
Jim Young <jyoung@xxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4157| |review_for_checkin?
Flag| |
Created an attachment (id=4157)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4157)
patch to update gui after save of an untitled file
Build Information:
Version 1.3.3 (SVN Rev 31580 from /trunk)
Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiled with GTK+ 2.18.5, with GLib 2.22.3, with WinPcap (version unknown),
with libz 1.2.3, without POSIX capabilities, without libpcre, with SMI 0.4.8,
with c-ares 1.7.0, with Lua 5.1, without Python, with GnuTLS 2.8.5, with Gcrypt
1.4.5, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built Jan 19
2010), with AirPcap, with new_packet_list.
Running on Windows XP Service Pack 3, build 2600, with WinPcap version 4.1.1
(packet.dll version 4.1.0.1753), based on libpcap version 1.0 branch 1_0_rel0b
(20091008), GnuTLS 2.8.5, Gcrypt 1.4.5, with AirPcap 4.1.0 build 1622.
Built using Microsoft Visual C++ 9.0 build 30729
--
This patch augments the "cf_cb_file_reload_finished" event callbacks to restore
expected GUI updates of the Wireshark title, recent files list and Status bar
when a "Save" of an previously "(Untitled)" capture file is requested.
Enhancements applied with SVN 31269 appears to have introduced some regressions
with Wireshark's title/recent file list/status bar after saving an "(Untitled)"
capture file.
For example file.c's set_display_filename() is no longer triggered when one
manually does a "Save as" of an "(Untitled)" capture file nor is the newly
saved capture file added to the list of Recent files. Also after saving the
capture, the status bar's file message displays the message "Ready to load or
capture" instead of the name of the newly saved capture file.
SVN 31268 is the last version with expected behavior when the "Save" button is
clicked on the "Save As" dialog for an "(Untitled)" capture file:
1) The title would change from "(Untitled)" to the filename entered within the
"Save As" dialog;
2) The newly named capture would be added to the list of "Recent files";
3) The status bar's file message area would be updated to display the filename,
filesize, and capture duration.
What changed.
SVN 31269 augmented cf_read() to include a new "from_save" flag. When
"from_save" is FALSE, cf_read() invokes the two events:
cf_cb_file_read_started
cf_cb_file_read_finished
When "from_save" is TRUE, cf_read() invokes two different events:
cf_cb_file_save_started
cf_cb_file_save_finished
The "cf_cb_file_save_finished" event callbacks do not trigger the GUI filename
updates that "cf_cb_file_read_finished" event callbacks do.
With the attached patch applied the "cf_cb_file_reload_finished" callbacks
trigger the GUI filename updates.
I'm not convinced this is the best way to resolve this problem but it does seem
to do the job of reflecting the name of the newly saved capture file to the
GUI.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
