Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 4394] New: Minor column functions clean up.

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

           Summary: Minor column functions clean up.
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Trivial
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: dgautheron@xxxxxxxx


Created an attachment (id=4139)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4139)
remove col_clear calls

Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
Hi,

Following patches remove redundant calls to check_col and col_clear.

col_clear.diff 
Remove calls to col_clear :
- called twice.
- before functions which also clear the column
- by replacing col_clear + col_append_xxx with col_add_xxx

check_col.diff
Remove redundant calls to check_col() if it guards only one columns function
with one parameter after the column type.

packet-cigi.c.diff
fix a memory leak by using se_strdup rather for g_strdup for column text.
replace col_clear() follow by col_add_str() with the faster col_set_str()
remove redundant check_col() call

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.