Wireshark-bugs: [Wireshark-bugs] [Bug 3677] new dissector for EtherCAT Switch Link Header added
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 2 Jan 2010 14:23:19 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3677

--- Comment #6 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-01-02 14:23:18 PST ---
(In reply to comment #4)
> And looking at packet-esl.[ch] how does this not violate this rule in
> README.developer:
> 
> <quote>
> Don't use structures that overlay packet data, or into which you copy
> packet data; the C programming language does not guarantee any
> particular alignment of fields within a structure, and even the
> extensions that try to guarantee that are compiler-specific and not
> necessarily supported by all compilers used to build Wireshark.  Using
> bitfields in those structures is even worse; the order of bitfields
> is not guaranteed.
> </quote>

Given no answer from the Richard Kümmel on this, I've committed a change to not
use bitfields in SVN #31412 (as well as making some other changes).

http://anonsvn.wireshark.org/viewvc?view=rev&revision=31412

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.