Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 4361] New: Makefile.nmake patch to trigger recompilation on svnversion.h chang

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4361

           Summary: Makefile.nmake patch to trigger recompilation on
                    svnversion.h change
           Product: Wireshark
           Version: 1.3.x (Experimental)
          Platform: Other
        OS/Version: Windows XP
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Extras
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: jyoung@xxxxxxx


Jim Young <jyoung@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4100|                            |review_for_checkin?
               Flag|                            |

Created an attachment (id=4100)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4100)
patch to Makefile.nmake to trigger recompilations on svnversion.h change

Build Information:
$ ./wireshark-gtk2/tshark -v
TShark 1.3.3 (SVN Rev 31378 from /trunk)

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GLib 2.22.3, with WinPcap (version unknown), with libz 1.2.3,
without POSIX capabilities, without libpcre, with SMI 0.4.8, with c-ares 1.7.0,
with Lua 5.1, without Python, with GnuTLS 2.8.5, with Gcrypt 1.4.5, with MIT
Kerberos, with GeoIP.

Running on Windows XP Service Pack 3, build 2600, with WinPcap version 4.1.1
(packet.dll version 4.1.0.1753), based on libpcap version 1.0 branch 1_0_rel0b
(20091008), GnuTLS 2.8.5, Gcrypt 1.4.5.

Built using Microsoft Visual C++ 9.0 build 30729

--
This patch modifies Makefile.nmake so that several dependant obj files will be
recompiled if and when the svnversion.h file should be updated.

The svnversion.h file itself is updated by the first nmake build after an "svn
update".    

With this patch applied several new obj targets are explicitly defined with
svnversion.h added as a prerequisite.

In addition the svnversion.h prerequisite is explicitly removed from the
executable targets that are related to the new obj targets.

The existing Makefile.nmake behavior simply triggers a relinking of any
dependant executables when svnversion.h should change.  Because svnversion.h is
listed as a prerequisite to an exe and not to the obj, the resulting executable
will often report obsolete svnversion.h information since re-compilation of the
dependent source code module is not triggered.

NOTE: While this patch improves one part of the nmake build process it does not
address other similar issues.  For example: changes to config.h should also
trigger recompilation of any dependant source modules and not simply a
relinking of their executables.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.