Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 4339] New: [PATCH] VNC dissector cleanups and minor changes

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4339

           Summary: [PATCH] VNC dissector cleanups and minor changes
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: mykaul@xxxxxxxxx


Created an attachment (id=4075)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4075)
[PATCH] VNC dissector cleanups and minor changes

Build Information:
SVN r31313
--
A batch of minor changes and cleanups to the VNC dissector (most are cosmetic):
1. Addition of few encoding types (no parsing yet)
2. Enumaration of several values
3. 'const'ifying some parameters that passed to functions
4. A bit of aid in desegmenting hextile encoding (does not solve the previous
bug that it still does not desegment it fully)
5. Changing all possible fields that are boolean to FT_BOOLEAN instead of
FT_UINT8. Example:
                  { "Share desktop flag", "vnc.share_desktop_flag",
-                   FT_UINT8, BASE_DEC, VALS(yes_no_vs), 0x0,
+                   FT_BOOLEAN, BASE_NONE, NULL, 0x0,
6. Same for bitmasks:
                  { "Mouse button #1 position", "vnc.button_1_pos",
-                   FT_UINT8, BASE_DEC, VALS(button_mask_vs), 0x1,
+                   FT_BOOLEAN, 8, TFS(&button_mask_vs), 0x1,

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.