Wireshark-bugs: [Wireshark-bugs] [Bug 4299] SocketCAN dissector patch
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 7 Dec 2009 13:15:52 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4299

--- Comment #11 from Felix Obenhuber <felix@xxxxxxxxxxxx> 2009-12-07 13:15:48 PST ---
(In reply to comment #10)
> > ARP Header: I don't know about the details. The value of 280 is widely used in the SocketCAN code. I'll ask the guys about.
[...]
> actually appear in ARP packets).  Unless ARP is used in CAN, the ARP dissector
> shouldn't be modified.

Can you give me a hint where to register the protocol instead of within the ARP
dissector? 

> Only if what it receives either corresponds to what's on the wire or to other
> relevant data; if the extra data at the end of the packet is just random
> padding or zero padding or something such as that, there's not much use in
> putting it into the capture.

You're right. I've updated the libpcap socketcan patch. The capture data length
is adjusted with dlc reported in the frame header. The change has no effect on
the WS dissector for SocketCAN.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.