Wireshark-bugs: [Wireshark-bugs] [Bug 4299] New: SocketCAN dissector patch
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 6 Dec 2009 14:24:47 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4299

--- Comment #6 from Felix Obenhuber <felix@xxxxxxxxxxxx> 2009-12-06 14:24:45 PST ---
* ARP Header: I don't know about the details. The value of 280 is widely used
in the SocketCAN code. I'll ask the guys about.

* License: No Problem. Will change to comment header accordingly and update the
patch.

* Linux specific header: The header is used to obtain the masks for gathering
the flags of the frame. I have been in doubt about a redefinition, but it's
easy to do so within WS code. As you wrote, it might be the most convenient way
to redefine, in order to make the dissector usable on non-Linux platforms.
Furthermore <bits/sockaddr.h> is only used to satisfy can.h's includes...
Update follows.

Thanks!

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.