https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140
--- Comment #17 from Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx> 2009-11-29 02:12:21 PST ---
(In reply to comment #16)
> (And, yes, I think emem_cleanup() is already doing more work than is really
> necessary, if it's to be called as part of the exit path. We already have to
> pop up a "Closing file! Please wait ..." dialog when exiting, which is a bug -
> applications shouldn't, after you ask them to quit, take so long to exit that
> you can see a dialog box saying it's quitting.)
You were thinking about epan_cleanup()?
IMHO the problem is in some closing file code, and not epan_cleanup().
If you close file, and than quit wireshark this dialog doesn't appear.
> Whether it's "best practice" to manually free all memory before calling exit()
> or returning from main() is a matter of debate.
So IMHO there're two solutions:
- remove _cleanup() code.
- leave as it is, create some configuration/environment variable which:
a/ would not free resources - faster quiting
b/ tries to free all resources - for valgrind users.
I don't mind which version will be default.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
