https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4189
--- Comment #8 from Markus <nepenthesdev@xxxxxxxxx> 2009-11-03 01:43:02 PDT ---
(In reply to comment #7)
To me, consistent indenting is as part of code-quality, as comments.
> 3) The original author of the file might disagree about the "hard to spot"
> thing - he may be used to reading code in that indentation style.
I filed the ticket, as I was debugging packet-dcerpc.c and the indenting is
inconsistent, using 4,2,1 and 0 spaces to indent.
For the bug, with consistent indenting, the proper location would have been
easier to spot.
> IMO, this bug should be closed as invalid, not even as an enhancement.
Fine, I just wanted to let you know the indenting inconsistency is a real
cradle for people like me who want to contribute patches for existing bugs.
Actually, my patch made things even worse, as there was no consistency within
indenting, I felt unable to indent correctly, just fixed the logic, so I broke
the indenting consistency even further.
> I completely agree with Jaap (Comment #6) that we already agreed quite some
> years ago to not agree on indenting style - leave it at that.
I think the file I'm referring to already suffers from this decision.
Of course people will argue initially about an indenting policy, for example I
prefer tabs for alignment and indent, others disagree, they got their points, I
got mine. Others may even object as they'd loose the freedom to indent their
code in their preferred way.
But once the rules exist and are applied to patches and commits, people will be
glad they exist.
I proposed uncrustify as you can define rules for *lots* many different cases
where you may want to enforce consistency, so everybody would able to indent
his contribution properly - using wiresharks uncrustify configuration-,
independent of the editor used.
I don't want to waste time discussing problems you obviously prefer to ignore,
therefore I won't subscribe to the ml and continue this discussion.
I made my point, you decided to stick with the 'there is no identing'-indenting
policy.
Due to my ticket, we all already wasted time on a historically prestressed
topic, I was unaware of this historically grown situation, I'm sorry I decided
to raise objection. Initially I felt it would be a good idea, now I have to
admit it was a waste of time.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
