Wireshark-bugs: [Wireshark-bugs] [Bug 3984] r29723 optimization, if (cinfo->col_data[col] != cin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 21 Sep 2009 01:46:43 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3984


didier gautheron <dgautheron@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




--- Comment #4 from didier gautheron <dgautheron@xxxxxxxx>  2009-09-21 01:46:39 PDT ---
Hi,

Attached packet display is still broken.

In r30012 ep_verify_pointer() only works if WIRESHARK_DEBUG_EP_NO_CHUNKS is set
and then it's not the kind of test you want to do in col_set_str before
check_col.

IMO the test should be moved to  packet_list_change_record:
if (cinfo->col_data[col] != cinfo->col_buf[col] && !ep_verify_pointer()) {
 record->fdata->col_text[col] = (gchar *) cinfo->col_data[col];
}
else
  se_memdup()

and many col_add_str can be moved back to col_set_str


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.