Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 4015] the Power Via MDI TLV for 802.3at dissector is incomplete

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4015





--- Comment #7 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2009-09-16 23:28:40 PDT ---
(In reply to comment #6)
> Created an attachment (id=3668)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3668) [details]
> a patch to complete the Power Via MDI TLV for 802.3at
> 
> Updated with value_strings, comments have been removed.  Patch was testing
> successfully on r29946.  Sorry it took me so many attempts to get it right.
> 

Oke, patch looks good now, thanks for hanging in there.
When working it to get it merged I found that
dissect_media_tlv()
        case 4: /* Extended Power-via-MDI */
does the same thing as you, and already has value_strings lined up (mostly)
ready to go. Can you see if these two can be shared/merged/use same
presentation?


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.