Wireshark-bugs: [Wireshark-bugs] [Bug 2902] Crash when loading capture file and Preferences: NO
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 19 Aug 2009 13:47:34 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2902





--- Comment #19 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2009-08-19 13:47:33 PDT ---
(In reply to comment #18)
> (In reply to comment #17)
> > From bug 3870: a new variant pops up in packet-dns.c and packet-nbns.c. Just a
> > check on (cinfo != NULL), no specific column check. 
> 
> Please note that cinfo is only set if having COL_INFO (dissect_dns_common and
> dissect_nbns), and is used for more than just checking if the column is
> present.
> 
> I think the code in packet-dns.c and packet-nbns.c is valid as it is.
> 

Hmmm, that's what you get when you have no time to look at it deeper. This
'off-label' use of cinfo can easily get you in the wrong direction. 


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.