Wireshark-bugs: [Wireshark-bugs] [Bug 3900] IEC104 Signal dissection added
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 15 Aug 2009 00:20:26 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3900


Jaap Keuter <jaap.keuter@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3514|review_for_checkin?         |review_for_checkin-
               Flag|                            |




--- Comment #2 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2009-08-15 00:20:10 PDT ---
(From update of attachment 3514)
There's non-ASCII text in there. 
Don't use tvb_memcpy(tvb, &cp56t->cp56t_min, *offset, 1); use the proper access
functions tvb_get_guint8().
Please use English comments for all to read.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.