Wireshark-bugs: [Wireshark-bugs] [Bug 3787] New fibre channel delimiter dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3787
--- Comment #6 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2009-08-11 04:02:02 PDT ---
(In reply to comment #3)
> (In reply to comment #1)
> > Please update the text in the header comment block to match the real situation.
> >
> > Don't call FC dissector only if tree!=NULL, it must always be called.
> >
> > Shouldn't you set pinfo->sof_eof, just as fcoe does?
> >
> > Shouldn't this fcsof dissector be integrated into the fc dissector?
> >
>
> I updated comments and pass to fc dissector no matter what.
Ok.
> I also populate pinfo->sof_eof according to delimiters.
Ok.
> The reason that I cannot integrate this in fc dissector is that other fc
> dissectors (such as fcoe) use fc dissector. The delimiter of FCOE only have 2
> bytes while native fc delimiters have 4 bytes.
>
> Beside this, FC without delimiter has another DLT type (224).
>
That argument doesn't fly. Multiple dissectors can live in the same source file
and register themselves independently. packet-udp.c is an example of that,
having both UDP and UDPLite sharing dissection code. packet-gsm_a.c is another
example having multiple separate dissection routines.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
