Wireshark-bugs: [Wireshark-bugs] [Bug 3764] GTK2 based packet list - patches
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 26 Jul 2009 14:33:32 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3764


Kovarththanan Rajaratnam <kovarththanan.rajaratnam@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3403|                            |review_for_checkin?
               Flag|                            |




--- Comment #34 from Kovarththanan Rajaratnam <kovarththanan.rajaratnam@xxxxxxxxx>  2009-07-26 14:33:29 PDT ---
Created an attachment (id=3403)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3403)
Optimize new_packet_list_append()/packet_list_append_record()

This patch optimizes new_packet_list_append()/packet_list_append_record() by:

1) Removing col_fmt from row_data. It wasn't being used. If we need to store
the column format in the future that should probably be placed in the
PacketList instead of the PacketListRecord
2) Remove double allocation of col_text. Now we allocate it in
new_packet_list_append() and pass it on to packet_list_append_record()
3) Use se_alloc instead of se_alloc0 because we explictly set all the
parameters we use.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.