Wireshark-bugs: [Wireshark-bugs] [Bug 3334] Columns fix and optimizations
Date: Fri, 10 Jul 2009 23:25:14 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3334


Kovarththanan Rajaratnam <kovarththanan.rajaratnam@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2878|review_for_checkin?         |
               Flag|                            |
Attachment #2878 is|0                           |1
           obsolete|                            |
   Attachment #3309|                            |review_for_checkin?
               Flag|                            |




--- Comment #11 from Kovarththanan Rajaratnam <kovarththanan.rajaratnam@xxxxxxxxx>  2009-07-10 23:25:06 PDT ---
Created an attachment (id=3309)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3309)
Update Jakub's patch to apply cleanly to r29061 + remove GLib < 2 workaround
(we now require >= 2.4)

I did some profiling on Jakub's patch and it provides a nice reduction in the
g_malloc() traffic in add_packet_to_packet_list().

There's one thing I think this patch also needs to address. In the gap between
27836 (Jakub's original patch) and 29061, we now have one more col_set_time()
caller - compare_stat.c. AFAICT, we can't lookup the hf id ("ZebraTime") for
this caller, so it defaults to -1.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.