Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3677] new dissector for EtherCAT Switch Link Header added to EtherCAT plugin

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3677


Bill Meier <wmeier@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wmeier@xxxxxxxxxxx




--- Comment #3 from Bill Meier <wmeier@xxxxxxxxxxx>  2009-07-07 10:15:42 PDT ---
What is the intent of the non-standard usage in the following in the hf[]
array?

        { &hf_esl_port, 
                { "Port", "esl.port",
                        FT_UINT16, BASE_DEC, NULL, 0x00,          
                        NULL, 0xC0FF, 0, 0, 0, NULL, NULL }

Explicitly specifying values for the last 6 entries rather than using HFILL
seems incorrect to me.

>From proto.h:

        /* ------- set by proto routines (prefilled by HFILL macro, see below)
------ */
        int                             id;         /**< Field ID */
        int                             parent;     /**< parent protocol tree
*/
        int                             ref_count;  /**< is this field
referenced by a filter and how often */
        int                             bitshift;   /**< bits to shift */
        header_field_info               *same_name_next; /**< Link to next
hfinfo with same abbrev */
        header_field_info               *same_name_prev; /**< Link to previous
hfinfo with same abbrev */
};

/**
 * HFILL initializes all the "set by proto routines" fields in a
 * _header_field_info. If new fields are added or removed, it should
 * be changed as necessary.
 */
#define HFILL 0, 0, 0, 0, NULL, NULL


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.