Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3652] Fuzz testing crash / dissector bug in MIOP

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3652


Kovarththanan Rajaratnam <kovarththanan.rajaratnam@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kovarththanan.rajaratnam@gma
                   |                            |il.com




--- Comment #3 from Kovarththanan Rajaratnam <kovarththanan.rajaratnam@xxxxxxxxx>  2009-07-03 12:00:32 PDT ---
(In reply to comment #2)
> Is
> 
>       tvb_memcpy (unique_id_len_tvb, (guint32 *)&(unique_id.id_len), 0, 4);
> 
> correct? Why aren't we simply fetching the value with tvb_get_ntohl or
> tvb_get_letohl?
> 

You're right. I didn't touch any of the tvb_xxx related stuff. It also struck
me as odd that we insist on creating alot of tvbuffs when we instead could
dissect from the tvbuff handed to us.

Do you want me to make that change to attachment 3248 or should I submit a new
patch on top of this?


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.