https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3543
--- Comment #18 from Jörg Mayer <jmayer@xxxxxxxxx> 2009-06-18 16:15:49 PDT ---
Just a question I forgot to ask: Is your dissector based on the 1.0 version of
the source or the 1.1/1.2/1.3 version of the source code? My v5 patches were
definitely post 1.0. It's possbile that my v5 patches broke something in the
v2/v4 code because I didn't have any test data for v2/v4, the red branch of
your image regarding v5 is the main part of what was missing from the recent
source version.
In the end, I don't mind whether my code is replaced, as long as the new v5
code is better than what I wrote - I only had one sample trace containing v5
records when I added v5 functionality and a dissector created/tested by the
authors of the protocol will have seen much better testing.
In order to be able to provide early feedback before you take up work on the
dissector again it would be good if InMon could give you permission to post the
current version of your code. Oh, the final version should of course not be a
plugin but simply replace the existing file.
Oh, one more thing: Do you have some sample captures (v2, v4, v5) that you
could provide so we can add them to the wireshark sample captures page (or even
better: could you add them directly :-) That way we can a) learn about how
sflow works and b) compare the output of the old version and the new version of
the dissector.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
