Wireshark-bugs: [Wireshark-bugs] [Bug 2533] EBCDIC display for TN3270 packet
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 2 Jun 2009 15:04:19 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2533





--- Comment #4 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2009-06-02 15:04:18 PDT ---
This patch needs more cleaning before it can become part of the main
repository.
- Indentations must be consistent (don't mix tabs and spaces)
- Drop not required includes.
- For telnet.c don't put in a parameter in comments in telnet_add_text()
- "Remove memleaks", a must do item.
- Remove the C++ style comments, non-portable
- Fix the header fields
- Drop the (Tor based?) preferences, they're not used


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.