Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3472] New: Fix: save/restore pinfo->private_data when used

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3472

           Summary: Fix: save/restore pinfo->private_data when used
           Product: Wireshark
           Version: 1.1.x (Experimental)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Medium
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: artem.tamazov@xxxxxxxxxxx


Build Information:
TShark 1.1.4-tlab-pwe3-atm (SVN Rev unknown)

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GLib 2.20.0, with WinPcap (version unknown), with libz 1.2.3,
without POSIX capabilities, with libpcre 7.0, with SMI 0.4.8, with c-ares
1.6.0,
without Lua, with GnuTLS 2.6.4, with Gcrypt 1.4.4, with MIT Kerberos, with
GeoIP.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.0.2
(packet.dll version 4.0.0.1040), based on libpcap version 0.9.5, GnuTLS 2.6.4,
Gcrypt 1.4.4.

Built using Microsoft Visual C++ 7.10 build 3077
--
As far as I see, the main use of pinfo->private_data is to pass information to
sub-dissectors. In such cases, the caller should save pinfo->private_data and
restore it after invoking all sub-dissectors it needs.

This blocks the development of MPLS ATM PW dissectors.

This patch fixes plenty of dissectors which do not follow this policy.
Most cases are trivial, except packet-rpc.c written by Uwe Girlich. 
This file left unchanged.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.