Wireshark-bugs: [Wireshark-bugs] [Bug 3445] New: Cops/PCMM Dissector - Gate Usage Info field ass
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 29 Apr 2009 11:07:29 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3445

           Summary: Cops/PCMM Dissector - Gate Usage Info field assumes 32
                    bit integer
           Product: Wireshark
           Version: 1.1.x (Experimental)
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Medium
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: jrenzullo@xxxxxxxxxxx



Jared Renzullo <jrenzullo@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2974|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=2974)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2974)
Patch file.

Build Information:
Version 1.1.4 (SVN Rev 28191)

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.10.4, with GLib 2.12.3, with libpcap 0.9.4, with libz
1.2.3, with POSIX capabilities (Linux), without libpcre, without SMI, without
c-ares, without ADNS, without Lua, with GnuTLS 1.4.1, with Gcrypt 1.2.4, with
MIT Kerberos, without GeoIP, without PortAudio, without AirPcap.
NOTE: this build doesn't support the "matches" operator for Wireshark filter
syntax.

Running on Linux 2.6.18-128.1.6.el5, with libpcap version 0.9.4, GnuTLS 1.4.1,
Gcrypt 1.2.4.

Built using gcc 4.1.2 20080704 (Red Hat 4.1.2-44).

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
The Gate Usage Info field was not displaying properly because the dissector
code was looking for a 32 bit integer, when the PCMM spec says the field is a
64 bit integer. I updated the field to display properly. I also fixed a bug
with the UserID field. The field was assuming the string was null terminated,
but the string is only null terminated if the original string's length was not
a multiple of four. I fixed this by getting the string based on the expected
length instead of the null terminator.

The patch has passed fuzz testing.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.