Wireshark-bugs: [Wireshark-bugs] [Bug 3422] New dissector for Genisys protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 20 Apr 2009 11:31:22 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3422





--- Comment #4 from Bruce Keeler <bruce@xxxxxxxxxxx>  2009-04-20 11:31:21 PDT ---
Jaap,

Thanks for the review.  When I first looked for crc16 functions, I only saw the
ccitt versions in crc16.[ch] and missed the lonely crc16_plain_tvb_offset at
the bottom.  My revised patch adds a new crc16_plain that uses the same
implementation but operates on a provided buffer.  (I can't crc the tvb
directly).

I'm little unclear on the first part of your comment.  Do you mean that
tvb_get_ptr might produce a pointer to a buffer that doesn't have 'length'
bytes?


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.