Wireshark-bugs: [Wireshark-bugs] [Bug 3265] New dissector: LDSS (local download sharing service)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3265
Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|Normal |Enhancement
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #4 from Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> 2009-03-28 22:03:03 PDT ---
This is a new feature, not a bug. Changed severity to reflect that.
Patch accepted and committed as SVN revision 27877. Thanks for your
contribution!
I made some minor changes to the patch before committing it:
- Changed Ethereal to Wireshark in top comments
- Moved protocol description below the copyright notice
- Fixed some formatting of value strings
- Noted that the UDP port is IANA assigned
- Flipped two lines in epan/dissectors/Makefile.common to maintain
alphabetical order
- Removed unused variables: hf_ldss_broadcasts, hf_ldss_broadcast,
udp_port_ldss
- Fixed compile errors/warnings on Unix:
packet-ldss.c: In function 'dissect_ldss_broadcast':
packet-ldss.c:388: warning: format '%ld' expects type 'long int', but argument
8 has type 'int'
packet-ldss.c: In function 'proto_reg_handoff_ldss':
packet-ldss.c:1016: warning: passing argument 1 of 'create_dissector_handle'
from incompatible pointer type
The first error was fixed by changing %ld to %d. The second was fixed by
changing create_dissector_handle() to new_create_dissector_handle() because it
is a new style dissector that returns the number of bytes dissected.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
