Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3357] New: NSIS packaging fail if VERSION_EXTRA contains a space character

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3357

           Summary: NSIS packaging fail if VERSION_EXTRA contains a space
                    character
           Product: Wireshark
           Version: SVN
          Platform: x86
        OS/Version: Windows XP
            Status: NEW
          Severity: Normal
          Priority: Medium
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: andreas.heise@xxxxxxxxxxxxx



Andreas Heise <andreas.heise@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2884|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=2884)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2884)
diff patch to fix wireshark.nsi 

Build Information:
wireshark 1.1.4-NextiraOne Build-003 (SVN Rev unknown)

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.16.0, with GLib 2.20.0, with WinPcap (version unknown),
with libz 1.2.3, without POSIX capabilities, with libpcre 7.0, with SMI 0.4.8,
with c-ares 1.6.0, with Lua 5.1, with GnuTLS 2.6.4, with Gcrypt 1.4.4, with MIT
Kerberos, with GeoIP, with PortAudio V19-devel (built Mar 24 2009), with
AirPcap.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.0.2
(packet.dll version 4.0.0.1040), based on libpcap version 0.9.5, GnuTLS 2.6.4,
Gcrypt 1.4.4, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729
--

if VERSION EXTRA in config.nmake contains a space character
then the NSIS packaging fails...

Section: "TShark" ->(SecTShark)
SetOutPath: "$INSTDIR"
File: "tshark.exe" 210432 bytes
File: "tshark.html" 49529 bytes
SectionEnd
SectionGroup Plugins / Extensions ->(SecPluginsGroup)
Section: "Dissector Plugins" ->(SecPlugins)
SetOutPath expects 1 parameters, got 2.
Usage: SetOutPath output_path
Error in script "wireshark.nsi" on line 784 -- aborting creation process
NMAKE : fatal error U1077: 'C:\Programme\nsis\makensis.exe' : return code '0x1'
Stop.
NMAKE : fatal error U1077: '"C:\Programme\Microsoft Visual Studio
9.0\VC\BIN\nma
ke.exe"' : return code '0x2'
Stop.
C:\wireshark>


A diff patch for the wireshark.nsi to fix this issue is attached


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.