Wireshark-bugs: [Wireshark-bugs] [Bug 3334] Columns fix and optimizations
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 15 Mar 2009 02:03:03 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3334


Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2860|                            |review_for_checkin?
               Flag|                            |




--- Comment #1 from Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx>  2009-03-15 02:03:01 PDT ---
Created an attachment (id=2860)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2860)
Replace col_expr.col_expr with pointer to header_field_info

By replacing col_expr.col_expr with col_ptr we should save some memory,
and it should be a little faster (no more g_strlcpy()),

Premature optimization is the root of all evil, but I think it will break
nothing,
of course if header_field_info pointer live at least as long as packet
frame_data.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.