https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3256
--- Comment #10 from Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx> 2009-03-02 05:39:03 PDT ---
(In reply to comment #3)
> You're almost there. I have a few comments about things that need to be
> addressed before we can include this protocol in Wireshark:
>
> - Remove the #if 1 / #endif block toward the top of packet-gg.c]
done.
> - Remove any printf() statements as dissectors should not be printing anything
> to the console unless it is being debugged
done.
> - A number of functions say "XXX, make it better" - make what better exactly?
make better code (or sometimes to make it look better) :) also done.
> - If an argument to a function is not used, don't set it equal to itself in the
> function to squelch the compiler warning. Instead, put _U_ after
I hope I fix it everywhere.
I also move proto_register_gg() & friends to bottom of packet-gg.c
(I saw somewhere comment is good practice to do it)
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
