Wireshark-bugs: [Wireshark-bugs] [Bug 3196] Enhancement to Expert Info Composite Tab Labels
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3196
--- Comment #4 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2009-01-18 11:22:22 PDT ---
(In reply to comment #3)
> Hello Japp,
>
> In reply to comment #2:
>
> > What is the change in gtk/expert_comp_table.h good for? An upcoming
> > improvement?
>
> There's an inconsistency lurking in the expert_tapdata_t typedef. See bug
> 2504 comment 3 for more details. In hindsight I should have submitted that
> particular "quick and dirty patch" as a separate bug report.
Yes, please submit separate patches for different purposes. Submitting is easy
(thanks to Subversion) and it helps when later looking back at specific
changes.
> And yes that
> change in gtk/expert_comp_table.h was ALSO related to a proposed
> improvement/enhancement to the Expert Info system that I documented in bug
> 2412. The "upcoming improvement" was probably 60% to 70% complete when I had
> to put that project on hold to deal other more urgent issues. (FWIW: I hope > to restart my efforts on bug 2412 in the next month or so time permitting.)
When it's done it's done.
> > Not everyone likes GUI candy, so my proposal is to make the presentation of
> > this icon dependent of the gtk-button-images property.
>
> I also think there is sometimes too much GUI for GUI's sake, but in this case
> I found the colors associated with these LED like images very useful in
> connecting the various Expert Info severity levels to the tabs. But I agree
> making this presentation configurable is an acceptable compromise. I'm
> embarrassed to ask, but where is the gtk-button-images property defined?
Sure it's useful, but that's personal taste, hence a good thing to make
configurable. See http://library.gnome.org/devel/gtk/stable/GtkSettings.html
That allows configuration from the gtkrc resource file.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
