Wireshark-bugs: [Wireshark-bugs] [Bug 2902] Crash when loading capture file and Preferences: NO
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2902
--- Comment #12 from didier gautheron <dgautheron@xxxxxxxx> 2009-01-15 00:00:07 PDT ---
(In reply to comment #11)
> Why not put the check into the API? This check has to be done always, so it
> might as well be done there. It removes the burden of checking the columns
> writability from the application (dissector/tap), just like was done for the
> proto_tree_add_xxx(tree, ...) where the check for tree!=NULL was made obsolete
> by adding it to the API, hence cleaning up the code a lot.
>
Yes it's an option.
But:
- by moving check_col inside col_xxx functions there's a small semantic change.
something like:
if (check_col(...) {
while(foo) {
col_append_xxx(....),
if (bar) col_set_writable(..., FALSE);
...
}
}
is currently possible.
- if we clean up the code, it could make backporting patches to the 1.0 branch
harder.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
