Wireshark-bugs: [Wireshark-bugs] [Bug 3170] New plugin to dissect collectd network packets
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 9 Jan 2009 05:01:29 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3170





--- Comment #9 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2009-01-09 05:01:28 PDT ---
Three things:
1. proto_register_collectd() doesn't need to be protected with initialized,
it's only called once.
2. hf[] entries where 'name' and 'blurb' are the same (like
hf_collectd_data_time has "Timestamp" twice) can have 'blurb' set to NULL.
3. Can you make the UDP port a preference? The collected man page says it can
be configured differently from the 25826 default. Have a look at packet-dis.c
in trunk on how to do that (Note: packet-dis.c code in 1.0.x is incorrect!)


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.