https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3165
--- Comment #3 from Tero Aho <tero.aho@xxxxxxxx> 2009-01-06 04:29:49 PDT ---
>FT_IPv4 and FT_IPv6 have no use for the base field, so not BASE_DEC but
>BASE_NONE.
Ok, fixed.
>Don't drop the volatile in "tvbuff_t *volatile next_tvb;" Certain compiler and
>Valgrind will make a scene due to the TRY/CATCH implementation.
Ok, fixed. This must have been some kind typo as it was not related to the
patch at all.
>When header field 'name' and 'blurb' fields are the same you can set the
>'blurb' field to NULL.
Ok, fixed.
>What's up with the field types 5 and 6? These are mentioned in the draft-09 but
>not present in the code.
Only types 1-4 were supported by the product in question. I didn't want to
implement wireshark support for the other types without the possibility to test
them in real environment. Nothing changed.
>Why all these complicated proto_tree_add_xxx calls? The header fields are setup
>already, why not just call proto_tree_add_item()?
I wanted to make it easy for someone else to add support for the other (more
complex) field types. For types 1-4 it would have been simpler to just add the
items which was the point of your comment, I think. Nothing changed.
I added a new patch having the fixes mentioned above.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
