Wireshark-bugs: [Wireshark-bugs] [Bug 3124] Enhancements for CCSDS Dissectors
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 19 Dec 2008 07:21:06 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3124





--- Comment #1 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-12-19 07:21:05 PDT ---
Quick review:
We've been Wireshark for some time now. Please don't roll back to the Ethereal
days.
We no longer depend on our own snprintf, so don't try to include that.
What's wrong with using GLib or libc provided time conversion functions? 
proto_register_ccsds() is not the place to setup value_string's, this is
normally done at module level.
value_string's are never directly included in header fields, they are to be
wrapped in VALS() macro.
Header fields with type FT_BOOLEAN use the 'display' field to set the width of
the parent bitfield (ref. README.developer). Do not change such sizes into
BASE_* values.
If header field 'names and 'blurb' fields are the same, fill 'blurb' with NULL.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.