Wireshark-bugs: [Wireshark-bugs] [Bug 3026] Enhanced OLSR packet dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 22 Nov 2008 03:56:50 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3026


Henning Rogge <rogge@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #2513 is|0                           |1
           obsolete|                            |




--- Comment #10 from Henning Rogge <rogge@xxxxxxx>  2008-11-22 03:56:48 PDT ---
Created an attachment (id=2514)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2514)
New dissector based on code review

First, thank you for the code review. I copied lot's of code from the old
dissector, so the coding style was not cleaned up enough, but I think the new
upload should address most points.

I replaced most "switch/case" constructs with value_string contructs.
I placed some "emergency breaks" in some while loops, but the IP family type is
still checked in dissect_olsr() before I enter the mainloop.
The blurb fields have been cleaned up (most set to NULL).
The format should now wrap consistent at ~120 characters (I run the whole thing
through the eclipse CDT formatter).


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.