Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3011] FIP dissector needs updates for recent protocol changes.

Wireshark-bugs: [Wireshark-bugs] [Bug 3011] FIP dissector needs updates for recent protocol chan

Date: Wed, 29 Oct 2008 23:54:47 -0700 (PDT)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3011





--- Comment #3 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-10-29 23:54:46 PDT ---
Patch looks good. I like to suggest two improvements:
1. For the code at line 324..338 (after applying patch that is) to add the
flags, please use the proto_tree_add_bitmask() function for that. 
2. In line 443 and 444, the unit for milliseconds is 'ms', not 'mS'.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

References:
- [Wireshark-bugs] [Bug 3011] New: FIP dissector needs updates for recent protocol changes.
  - From: bugzilla-daemon

Prev by Date: [Wireshark-bugs] [Bug 2993] Compilation broke when compiling without zlib
Next by Date: [Wireshark-bugs] [Bug 3013] Simplfy/generalize proto_tree_add_bits_ret_val()
Previous by thread: [Wireshark-bugs] [Bug 3011] FIP dissector needs updates for recent protocol changes.
Next by thread: [Wireshark-bugs] [Bug 3011] FIP dissector needs updates for recent protocol changes.
Index(es):
- Date
- Thread