Wireshark-bugs: [Wireshark-bugs] [Bug 2966] TTTech TTE plugin (dissector)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 20 Oct 2008 03:06:23 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2966





--- Comment #5 from Benjamin Roch <benjamin.roch@xxxxxxxxxx>  2008-10-20 03:06:22 PDT ---
Hi,
Thanks for you response - I incorporated the changes as you proposed. Since our
implementation consists of a heuristic dissector and the PCF dissector - is it
a good idea to enable this by default? 
How can a catch the settings from the protocls enable/disable?

Thanks in advance, 
  Benjamin

(In reply to comment #4)
> Well prepared, a few remarks though:
> -Move from plugin to regular dissector.
> -Add 88d7 as regular ethertype to etypes.h and packet-ethertype.c
> -Implement this comment: /* PCF preference dialog removed in shiping verison */
> -Remove enable preference as well, we have enabled protocols for that.
> -You can leave proto_reg_handoff_tte_pcf() can be left empty.
> -Don't include <prefs.h> if you don't need it.
> 


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.